[p4Tools and p4Testgen] New exploration strategy for test generation #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannelita
force-pushed
the
ht/toolsRandomExplMaxCov
branch
from
48ecec8
to
2007047
Compare
fruffy
reviewed
Oct 12, 2022
| /// path. | ||
| using Callback = std::function<bool(const FinalState&)>; | ||
|
|
||
| using Branch = ExplorationStrategy::Branch; |
There was a problem hiding this comment.
Redeclaring these types is not needed iirc.
| @@ -84,11 +85,14 @@ int Testgen::mainImpl(const IR::P4Program* program) { | |||
| auto symExec = [&solver, &programInfo, seed]() -> ExplorationStrategy* { | |||
| std::string explorationStrategy = TestgenOptions::get().explorationStrategy; | |||
| if (explorationStrategy.compare("randomAccessStack") == 0) { | |||
| // If the user mistakenly specifies an invalid popLevel, we set it to 3. | |||
There was a problem hiding this comment.
Can we also emit a warning here? For all these cases where the user is mistaken.
There was a problem hiding this comment.
Oh I was actually referring to the line below, which silently overrides the inputs.
hannelita
force-pushed
the
ht/toolsRandomExplMaxCov
branch
from
d0ea5d5
to
ed3c770
Compare
fruffy
reviewed
Oct 19, 2022
backends/p4tools/testgen/testgen.cpp
Outdated
| @@ -97,6 +104,14 @@ int Testgen::mainImpl(const IR::P4Program* program) { | |||
| if (explorationStrategy.compare("maxCoverage") == 0) { | |||
| return new IncrementalMaxCoverageStack(solver, *programInfo, seed); | |||
| } | |||
| if (explorationStrategy.compare("randomAccessMaxCoverage") == 0) { | |||
| // If the user mistakenly sets and invalid saddlePoint, we set it to 5. | |||
There was a problem hiding this comment.
Suggested change
| // If the user mistakenly sets and invalid saddlePoint, we set it to 5. | |
| // If the user mistakenly sets an invalid saddlePoint, we set it to 5. |
fruffy
reviewed
Oct 19, 2022
| } | ||
|
|
||
| // If there's no element in bufferUnexploredBranches with the particular coverage | ||
| // we calculate, we'll insert a new key at bufferUnexploredBranches |
There was a problem hiding this comment.
Missing dot, this time for real.
… random access max coverage [no-jira]
[no-jira]
[no-jira]
[no-jira]
hannelita
force-pushed
the
ht/toolsRandomExplMaxCov
branch
from
5f0d047
to
8e6e97f
Compare
fruffy
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New exploration strategy combining random exploration and max coverage.
[no-jira]