Fix selector input check for shared action selectors #358
Conversation
backends/bmv2/jsonconverter.cpp
Outdated
| } else if (auto mem0 = expr0->to<IR::Member>()) { | ||
| auto mem1 = expr1->to<IR::Member>(); | ||
| return checkSameKeyExpr(mem0->expr, mem1->expr) && mem0->member == mem1->member; | ||
| } else if (auto c0 = expr0->to<IR::Constant>()) { |
There was a problem hiding this comment.
Here you may use to<IR::Literal>; this will handle booleans and enums, in case these are legal in key expressions.
For these cases you can probably use the natural equality operator expr0->operator==(*expr1), since these are leaf expressions.
There was a problem hiding this comment.
I lied, that won't hande enums, but it will handle booleans.
There was a problem hiding this comment.
On my TODO list is extending the ir-generator to allow virtual args to methods, so as to make it easy to write a deep-compare function for expressions, or any other thing that needs multiple dynamic dispatch of IR class types.
There was a problem hiding this comment.
@mbudiu-vmw I implemented the change you suggested
backends/bmv2/jsonconverter.cpp
Outdated
| } else if (auto mem0 = expr0->to<IR::Member>()) { | ||
| auto mem1 = expr1->to<IR::Member>(); | ||
| return checkSameKeyExpr(mem0->expr, mem1->expr) && mem0->member == mem1->member; | ||
| } else if (auto c0 = expr0->to<IR::Constant>()) { |
There was a problem hiding this comment.
On my TODO list is extending the ir-generator to allow virtual args to methods, so as to make it easy to write a deep-compare function for expressions, or any other thing that needs multiple dynamic dispatch of IR class types.
antoninbas
force-pushed
the
action-selector-sharing
branch
from
2709f9d
to
f3ca186
Compare
antoninbas
force-pushed
the
action-selector-sharing
branch
from
f3ca186
to
9e8547e
Compare
No description provided.