Dpdk Backend: Minor changes to add error check for mask operands and adding optional match kind to pna.p4 #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| selector /// Used for dynamic action selection via the ActionSelector extern | ||
| range, /// Used to represent min..max intervals | ||
| selector, /// Used for dynamic action selection via the ActionSelector extern | ||
| optional /// Either an exact match, or a wildcard matching any value for the entire field |
There was a problem hiding this comment.
Right now the PNA spec does not even specify the match kinds. It just says:
TBD: Consider simply referencing the corresponding section of the PSA specification for this, unless we want to have something different in PNA.
It seems like it is best if we decide on the spec of match kinds here before adding to things to DPDK pna implementation.
There was a problem hiding this comment.
There is one existing PR, and another that I believe Nate Foster is working on, that would add optional match_kind to PNA: p4lang/pna#62
It has been in v1model and PSA for over a year now, I believe, and I thought it was already in PNA, but must have neglected to add it when it was added to PSA. I can add this as a discussion topic for the 2022-Oct-24 public PNA meeting.
|
Since optional mathckind PR p4lang/pna#62 is now merged, can I get a review on this PR. |
mihaibudiu
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.