Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow Type_Control as a tuple argument #3753

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Disallow Type_Control as a tuple argument #3753

merged 2 commits into from
Dec 4, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu mbudiu@vmware.com

Disallow Type_Control as a tuple argument
0d94633 
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@mihaibudiu
Copy link
Contributor Author

Fixes #3750

jafingerhut
jafingerhut approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As usual I am reviewing the test programs and expected outputs.

@apinski-cavium
Copy link

Thanks for the fix. I also get the same compiler bug with:

extern ct
{
  void f();
}
void f(tuple<ct> t)
{
  t[0].f();
}

As Type_Extern is not a Type_ArchBlock nor a IContainer.

Forbid externs as tuple arguments
0b30c0b 
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
rst0git
rst0git approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit 35b9dbf into p4lang:main Dec 4, 2022
@rst0git rst0git mentioned this pull request Dec 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rst0git rst0git rst0git approved these changes

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihaibudiu @apinski-cavium @jafingerhut @rst0git