Do not visit the 'type' field in IR:Expressions by default

[ChrisDodd]

The main part of this change is actually fixing the various places it was using the child_index (at least one of which was off-by-one and didn't actually need to be changed as a result).

Also had to add an explicit Constant::visit_children that visits the type, as there seem to be a number of places that depend on that.

[mbudiu-bfn]

I will merge these.
Thank you!
Mihai

On Wed, May 4, 2016 at 3:18 PM, Chris Dodd notifications@github.com wrote:

The main part of this change is actually fixing the various places it was
using the child_index (at least one of which was off-by-one and didn't
actually need to be changed as a result).

Also had to add an explicit Constant::visit_children that visits the type,

as there seem to be a number of places that depend on that.

You can view, comment on, or merge this pull request online at:

#38
Commit Summary

• Do not visit the 'type' field in IR:Expressions by default

File Changes

• M frontends/p4/typeChecking/typeChecker.cpp
  https://github.com/p4lang/p4c/pull/38/files#diff-0 (21)
• M frontends/p4/typeChecking/typeChecker.h
  https://github.com/p4lang/p4c/pull/38/files#diff-1 (5)
• M frontends/p4v1/typecheck.cpp
  https://github.com/p4lang/p4c/pull/38/files#diff-2 (16)
• M ir/base.def https://github.com/p4lang/p4c/pull/38/files#diff-3
  (2)
• M ir/expression.def
  https://github.com/p4lang/p4c/pull/38/files#diff-4 (1)
• M ir/v1.cpp https://github.com/p4lang/p4c/pull/38/files#diff-5
  (2)
• M midend/local_copyprop.cpp
  https://github.com/p4lang/p4c/pull/38/files#diff-6 (2)

Patch Links:

• https://github.com/p4lang/p4c/pull/38.patch
• https://github.com/p4lang/p4c/pull/38.diff

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#38