[P4Testgen] Resolve array indices in the interpreter instead of converting them in a compiler pass. #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy-bfn
force-pushed
the
fruffy/accept_arrayindex
branch
2 times, most recently
from
30a91e2
to
670df2c
Compare
fruffy-bfn
changed the title
fruffy-bfn
force-pushed
the
fruffy/accept_arrayindex
branch
3 times, most recently
from
8bb18f1
to
b54885d
Compare
fruffy-bfn
force-pushed
the
fruffy/accept_arrayindex
branch
from
b54885d
to
87a5a97
Compare
fruffy-bfn
force-pushed
the
fruffy/accept_arrayindex
branch
from
87a5a97
to
2d3fcaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ArrayIndices within P4Testgen. We extend the compare function of state variables to also support indices and add an additional visitor function.
With this change, we can remove some of the conversion passes that caused the P4 IR to not type check after the mid end.