Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the TC defines in a namespace, use constexpr. #4048

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Wrap the TC defines in a namespace, use constexpr. #4048

merged 1 commit into from
Jun 26, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jun 26, 2023

Fixes #4028.

mihaibudiu
mihaibudiu approved these changes Jun 26, 2023
View reviewed changes
backends/tc/tc_defines.h Outdated
#define EXACT_TYPE 0
#define LPM_TYPE 1
#define TERNARY_TYPE 2
namespace TcConstants {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just TC?

@fruffy fruffy merged commit e741876 into main Jun 26, 2023
@fruffy fruffy deleted the fruffy/tc_const_class branch June 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p4tc pollutes IR-generated.h with generic #defines
2 participants
@fruffy @mihaibudiu