Fixed ebpf_packetOffsetInBits field in parser and control_block C file #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
komaljai
commented
Nov 9, 2023
•
komaljai
commented
- In the control block C file, the code is checking to see if the parsed packet is smaller than the packet that will be generated by the deparser. The problem is that ebpf_packetOffsetInBits is set by the parser C file, but is not being passed on to the control block C file. The solution is to make ebpf_packetOffsetInBits part of the eBPF map struct in header file, which is included in both parser and control block C file
- Change permisson for default action.
- Convert header fields to host endian in parser.c file
|
I see the fedora and ptf tests are failing, and it is not related to this PR, Are others also facing the same issue? |
usha1830
approved these changes
Nov 14, 2023
fruffy
pushed a commit
that referenced
this pull request
Nov 21, 2023
#4233) * Fixed ebpf_packetOffsetInBits field in parser and control_block C file * Move pna.h from tc runtime to ebpf runtime * Change Permisson for Default Action. * Reverse endianess conversion - Convert header fields to host endian * Reverse movement of pna.h file from ebpf/runtime to tc/runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.