Report offending node in the type-checker immutability check #4238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the compiler would produce only a very vague error message if type checking runs in immutable mode and the IR tree is actually modified. This is extremely annoying to debug. Therefore, I've added the check after each node is processed and the check now reports the offending node.
I've also modified the
end_apply
function (which still prints the generic check, although it is probably redundant):end_apply