[P4Testgen] Fix accidental system file categorization. #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
reviewed
Dec 8, 2023
| PUBLIC "${CMAKE_BINARY_DIR}/common" | ||
| PUBLIC "${P4C_SOURCE_DIR}" | ||
| PUBLIC "${P4C_BINARY_DIR}" | ||
| SYSTEM BEFORE PUBLIC ${P4TOOLS_Z3_INCLUDE_DIR} |
There was a problem hiding this comment.
From https://cmake.org/cmake/help/latest/command/target_include_directories.html it seems that the SYSTEM should be actually specified at the beginning, I'm a bit surprised this works. I think it would be best to split the system and non-system libraries to a separate target_include_directories.
fruffy
force-pushed
the
fruffy/fix_system_files
branch
from
8dfeddb
to
596767f
Compare
vlstill
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files were accidentally classified as system files, although they were local. This causes problems with such as tools as include-fixer.