Add missing includes exposed by non-unified build #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
approved these changes
Apr 4, 2017
|
@sethfowler could we catch this in regression by using a max chunk size of 1 for the unified build? But then I suppose we should also run a regression with a max chunk size of infinity to fully validate the unified build. Would it be possible to have Travis do one build with 1 and one build with infinity (in parallel), or don't you think it is worth it? |
|
It will make the build run much slower, unfortunately. For that reason I kinda hesitate to gate PRs on it. Travis also supports cron jobs, though, and maybe for something low priority like this, that's a good approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.