Improve diagnostics for BaseListExpression
#4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafingerhut
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I am reviewing the changes in the error messages, not the C++ code implementation changes. All but one of the error message changes look like improvements to me. The one exception seems "no worse", in that it shows an expression involving tmp that is not in the source code, but the original error message showed only ListExpression. I would not hold that strongly against this PR, unless someone more knowledge about the p4c internals believes that is the tip of the iceberg of a larger problem.
kfcripps
force-pushed
the
improve-diagnostics-listexpr
branch
from
c26abeb
to
b8375e1
Compare
|
Rebased |
|
This PR also suffers from #4357 (comment). Converting to draft for now. |
kfcripps
force-pushed
the
improve-diagnostics-listexpr
branch
from
850b41d
to
f840b23
Compare
fruffy
approved these changes
Jan 25, 2024
kfcripps
force-pushed
the
improve-diagnostics-listexpr
branch
from
f840b23
to
1fd19b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.