Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant protobuf installation in the CI build scripts. #4379

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jan 30, 2024

We do not need this piece of code anymore now that these packages are part of requirements.txt

@fruffy fruffy marked this pull request as ready for review January 30, 2024 17:38
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy force-pushed the fruffy/remove_extra_install branch from 7dbc8c0 to ecb01c4 Compare January 30, 2024 18:04
@fruffy fruffy enabled auto-merge (squash) January 30, 2024 18:04
@fruffy fruffy merged commit ac98f4c into main Jan 30, 2024
16 checks passed
@fruffy fruffy deleted the fruffy/remove_extra_install branch January 30, 2024 18:54
fruffy-g pushed a commit to fruffy-g/p4c that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants