Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hvec_map insert/emplace #4458

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix hvec_map insert/emplace #4458

merged 2 commits into from
Feb 25, 2024

Conversation

ChrisDodd
Copy link
Contributor

  • should not replace the value if the key is already present

@ChrisDodd ChrisDodd requested a review from asl February 23, 2024 06:19
@asl
Copy link
Contributor

asl commented Feb 23, 2024

Can we also add count while here?

@ChrisDodd
Copy link
Contributor Author

Can we also add count while here?

sure

asl
asl approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@asl asl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Feb 23, 2024
@ChrisDodd
Fix hvec_map insert/emplace
23f2dc7 
- should not replace the value if the key is already present
@ChrisDodd ChrisDodd force-pushed the cdodd-hvec branch 2 times, most recently from 2684816 to 5d94230 Compare February 24, 2024 05:11
@ChrisDodd ChrisDodd added this pull request to the merge queue Feb 25, 2024
Merged via the queue into p4lang:main with commit aa39f9f Feb 25, 2024
16 checks passed
@ChrisDodd ChrisDodd deleted the cdodd-hvec branch February 25, 2024 01:49
@ChrisDodd ChrisDodd mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asl asl asl approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisDodd @asl @fruffy