Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dowload pre-built Z3 on Macs as well #4476

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Dowload pre-built Z3 on Macs as well #4476

merged 1 commit into from
Feb 27, 2024

Conversation

asl
Copy link
Contributor

@asl asl commented Feb 27, 2024

No description provided.

@asl asl requested a review from fruffy February 27, 2024 05:44
@asl
Copy link
Contributor Author

asl commented Feb 27, 2024

I checked – it works on my M1 laptop

vlstill
vlstill approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way of checking on mac, but the change looks good to me, thank you.

fruffy
fruffy approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M1 testing now seems available, although I have not finished fixing the install script yet:
#4393

There are some differences in the way Homebrew works across the MacOS versions.

@asl asl added this pull request to the merge queue Feb 27, 2024
Merged via the queue into p4lang:main with commit 6108a79 Feb 27, 2024
16 checks passed
@asl asl deleted the z3-mac branch February 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

@vlstill vlstill vlstill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asl @vlstill @fruffy