Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Dockerfile for stable, Ubuntu 16.04-based builds #452

Merged
merged 3 commits into from
Apr 10, 2017

Conversation

sethfowler
Copy link
Contributor

This PR makes several changes to the Dockerfile to bring it in sync with changes made in upstream repos:

  • It's now based on Ubuntu 16.04.
  • It's built from the stable tag of behavioral-model.
  • It supports different image variants for normal builds and testing. This lets downstream repos which don't need to run the tests use a smaller version of the image. (To support this, we need to install p4c globally in the Dockerfile, so we now run make install.) The approach is the same one we used in the behavioral-model repo.
  • Just as in upstream repos, we're now excluding unneeded files via a .dockerignore file.

@sethfowler sethfowler self-assigned this Apr 7, 2017
@sethfowler sethfowler requested a review from cc10512 April 7, 2017 03:46
@sethfowler sethfowler changed the title Update the Dockerfile for stable, Ubuntu 16.04-based based Update the Dockerfile for stable, Ubuntu 16.04-based builds Apr 7, 2017
@sethfowler sethfowler force-pushed the seth/update-docker branch from 48287bc to 2605c21 Compare April 7, 2017 03:46
@sethfowler
Copy link
Contributor Author

By the way, the tests will fail until I merge the PRs in third-party and behavioral-model. Once this code gets reviewed, I'll merge them all at the same time.

@sethfowler
Copy link
Contributor Author

So p4c currently depends on BMV2 features which aren't in the BMV2 stable branch. At the moment, unfortunately, we'll have to continue depending on behavioral-model:latest. When another release of BMV2 is cut, we can cut a stable release of p4c at that point.

@sethfowler sethfowler merged commit 61e090b into p4lang:master Apr 10, 2017
@sethfowler sethfowler deleted the seth/update-docker branch April 10, 2017 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants