Move model instances into one source file, so they get initialized in the correct order #467
Conversation
|
In the long term, the right fix here is to minimize our use of global variables and not depend implicitly on static initialization order. |
|
|
||
| /* These must be in the same compiliation unit to ensure that P4CoreLibrary::instance | ||
| * is initialized before V1Model::instance */ | ||
| namespace P4V1 { |
There was a problem hiding this comment.
The name of this cpp file should be changed.
It should perhaps be called "modelInstances.cpp"
There was a problem hiding this comment.
I confirm that this fixes the issue which was originally reported by the LLVM Address Sanitizer. However, as @sethfowler pointed out, I think these global variables should be avoided by using a singleton pattern or by using global raw pointers.
|
This was meant to be a singleton pattern, but I guess in C++ you have to do much more work to create one. |
|
It's not really that much work. =) Both of the approaches Antonin suggested require only a couple of lines of code - for the raw pointer approach, all you need to do is explicitly initialize the variable somewhere before it's used, while for the singleton pattern you just need to wrap accesses to the variable in a function and perform initialization in that function. Call sites need to be updated in both cases, though. |
|
renamed the file to modelInstances.cpp |
… the correct order.
No description provided.