Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P4Testgen logging cleanups. #4684

Merged
merged 2 commits into from
Jul 2, 2024
Merged

P4Testgen logging cleanups. #4684

merged 2 commits into from
Jul 2, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented May 27, 2024

  • Move the log helpers from utils.h to logging.h
  • Use printInfo instead of printFeature where possible.
  • Qualify the logging labels with a "tools_" prefix.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label May 27, 2024
@fruffy fruffy requested a review from vlstill May 27, 2024 16:56
@fruffy fruffy requested a review from jnfoster June 11, 2024 19:39
@fruffy
Copy link
Collaborator Author

fruffy commented Jun 11, 2024

@vlstill Could you give this a review? Small and inconsequential changes.

vlstill
vlstill reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for a code that already existed, but when cleaning it it would make sense to me to resolve these too.

backends/p4tools/common/lib/logging.h Outdated Show resolved Hide resolved
backends/p4tools/common/lib/logging.h Outdated Show resolved Hide resolved
@fruffy
Some logging fixes.
7b183ab 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy force-pushed the fruffy/testgen_logging branch 2 times, most recently from 868bd7f to 3270ac5 Compare July 2, 2024 13:18
@fruffy
Return when the logging level does not match.
aaec7e7 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit a484745 Jul 2, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/testgen_logging branch July 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlstill vlstill vlstill approved these changes

@jnfoster jnfoster Awaiting requested review from jnfoster

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @vlstill