Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check compiler version in configure.ac #470

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Check compiler version in configure.ac #470

merged 1 commit into from
Apr 12, 2017

Conversation

sethfowler
Copy link
Contributor

This patch adds a check in configure.ac that p4c is being built with a supported compiler version. I check for GCC 4.9 or Clang 3.3.

@sethfowler sethfowler self-assigned this Apr 12, 2017
@sethfowler sethfowler requested a review from cc10512 April 12, 2017 00:19
mihaibudiu
mihaibudiu approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I guess something similar can be done for bmv2 as well?

@sethfowler
Copy link
Contributor Author

Yep, we could do the same thing there. @antoninbas would have to do it, though; I'm not sure what version constraints BMV2 has.

@mihaibudiu
Copy link
Contributor

When we generate JSON we put the JSON version in the output file.
That should somehow be checked against the installed BMv2 simulator.
Indeed, it is not clear how to map that easily to the version printed by simple_switch -v

@sethfowler sethfowler merged commit 100a8a6 into p4lang:master Apr 12, 2017
@sethfowler sethfowler deleted the seth/check-compiler-version branch April 12, 2017 02:57
@fefer fefer mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@cc10512 cc10512 Awaiting requested review from cc10512

Assignees

@sethfowler sethfowler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethfowler @mihaibudiu