Fix for issue #425 #472
Merged
Fix for issue #425 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfowler
approved these changes
Apr 12, 2017
There was a problem hiding this comment.
Looks good from my perspective. @antoninbas, do you have any test cases you want to verify this against?
|
This doesn't update the P4Runtime serializer. I'll wait for it to be updated before I test this. |
|
Ah yes, that's a good point. Verifying it does what's needed would be much easier with an accompanying P4Runtime serializer patch. |
|
Merging this, I'm going to update the P4Runtime serializer to leverage this as I need it ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @hidden annotations to compiler-synthesized actions and tables.