Add DCO description to the contribution guidelines.

[fruffy]

Now that we are part of the Linux foundation we will switch away from the ONF CLA to DCO for Github pull requests and contributions. DCO is the main mode of license management for LF projects. The nice part is that, compared to the ONF CLA, it does not require manager approval for company contributions. This should greatly simplify the contribution process.

We will selectively enable DCO on some repositories to test it. Nothing much should change for contributors. The only thing that is necessary is to sign your commits on PRs with Signed-off-by: .

https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

Provides good tips on how to manage contributing to a DCO repository. Commit hooks are the easiest mechanism to automate signoff.

[jafingerhut]

LGTM

[jafingerhut]

Might want to add an example command line git commit --signoff that shows one easy way to add the line required by Github to approve DCO?

Also, your commit does not have DCO :-)

[fruffy]

Might want to add an example command line git commit --signoff that shows one easy way to add the line required by Github to approve DCO?

Currently looking into ways to make this more convenient. Unfortunately, it looks like the inconvenience is by design. There is no git configuration that allows you to sign your commits automatically. Fwiw the failing CI test contains instructions on how to fix the commit, too.

Also, your commit does not have DCO :-)

Yes, intentionally! I am trying a configuration option that lets you sign a PR retroactively.

[fruffy]

It looks like there is currently no way around signing every commit. At the same time you can not automate your local git config to always add -s. The reason is that signing off commits must be ✨intentional✨. This is quite tedious.

[jafingerhut]

You could recommend people use a Bash alias like alias gc='git commit --signoff', or equivalent one-line script, if this is by design.

[jafingerhut]

I have not tried this, but if it works, perhaps you would consider it less onerous?

https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md#sign-off-option-2-repository-based-hooks

[fruffy]

I have not tried this, but if it works, perhaps you would consider it less onerous?

https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md#sign-off-option-2-repository-based-hooks

This would be a local git hook every user has to set up for their repository. But this document seems quite useful in general, maybe we can copy it.

[vlstill]

Is this an alternative to CLA, or is this in addition to it? What is the reason behind the change? I could have easily missed something as I did not pay attention lately, but I thing the PR itself should describe what is going on as this could have significant impact on downstream development, especially where the CLA is handled by Corporations' legal department.

[AdarshRawat1]

Is this an alternative to CLA, or is this in addition to it?

DCO will be replacing CLA, and we will migrate slowly.

What is the reason behind the change?

To simplify the contribution process by eliminating the need for manager approval for company contributions.
Context - We are now part of the Linux Foundation and DCO, is the standard for Linux Foundation projects.

[fruffy]

Is this an alternative to CLA, or is this in addition to it? What is the reason behind the change? I could have easily missed something as I did not pay attention lately, but I thing the PR itself should describe what is going on as this could have significant impact on downstream development, especially where the CLA is handled by Corporations' legal department.

Basically what Adarsh said. It replaces the CLA. I made a little writeup here but we will broadcast on the mailing lists too once it is rolled out on every repository:
https://p4lang.zulipchat.com/#narrow/stream/438567-general/topic/Switching.20to.20DCO.20for.20Github.20Contributions/near/445599416

Still trying to figure out how to make signed commits convenient...

[fruffy]

Adding a commit hook like this appears to be the most convenient option for DCO:
https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md#sign-off-option-2-repository-based-hooks