Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around automake bug related to recheck #475

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

sethfowler
Copy link
Contributor

Here's the fix for the make recheck bug that some team members have been encountering. For details, please check the comment in the patch.

If there's a nicer way to handle this, I'd love to hear about it. =)

@sethfowler sethfowler self-assigned this Apr 13, 2017
@sethfowler sethfowler requested a review from cc10512 April 13, 2017 03:03
@sethfowler sethfowler force-pushed the seth/fix-automake-recheck-bug branch from be6b627 to f9404cd Compare April 13, 2017 03:04
Copy link
Contributor

@cc10512 cc10512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if just adding an extra dependence to all-am will result in both all and all-am to be built, or make will figure out that they depend on the same set of targets.

If not, I don't really have a better idea :(

@sethfowler
Copy link
Contributor Author

Frustratingly I don't think that'll work, because "all" doesn't declare its dependencies accurately. It only depends on $(BUILT_SOURCES) and config.h.

This should really be fixed upstream. I'll file a bug against automake.

@sethfowler sethfowler force-pushed the seth/fix-automake-recheck-bug branch from f9404cd to c92657e Compare April 13, 2017 04:30
@sethfowler sethfowler merged commit d30f436 into p4lang:master Apr 13, 2017
@sethfowler sethfowler deleted the seth/fix-automake-recheck-bug branch April 13, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants