-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs : Add Home page for documentation #4764
Conversation
The first diagram looks impressive. Should there be links in the figure to different parts of the docs? The 3 big sub-figures at the bottom seem to take me back to the same page, rather than going to relevant sections of the documentation. Is this part of the work-in-progress for this PR? Also many of the doxygen headings are back to README in that generated page. Perhaps this PR is based on an older version of the p4c repo that doesn't have some recent commits merged in? |
Thank you
No, it is a static diagram
This is still a work in progress because, we haven't added those sections to our documentation yet. They will be added in this PR Check this commit.
Yes, you guessed it right !! I'll update the PR soon . |
This sounds interesting, I'll give it a try. |
There seem to be redundant copies of the same .svg figure in the docs/assets and docs/doxygen directories. Can that be removed? |
docs/doxygen/Doxymain.md
Outdated
<div class="diagram-container"> | ||
<!-- draw.io diagram --> | ||
<div class="mxgraph" style="" data-mxgraph="{"highlight":"#0000ff","lightbox":false,"nav":true,"edit":"_blank","url":"https://drive.google.com/uc?id=16X8Z_4-J8mHQPxuxm9HjWppPMTTXZdZ6&export=download"}"></div> | ||
<script type="text/javascript" src="https://viewer.diagrams.net/embed2.js?&fetch=https%3A%2F%2Fdrive.google. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should not rely on google drive here. Can we upload this to Github somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but, couldn't find a way to embed it via GitHub without compromising on functionality. Draw.io supports sharing only from Google Drive.
I'll see if I can find a workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to save or export a .svg file from draw.io and save that anywhere you like, e.g. in this Github repo, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to save or export a .svg file from draw.io and save that anywhere you like, e.g. in this Github repo, yes?
Indeed, I have included the diagram SVG and Draw.io file in this Pull Request.
Context - We want the SVG to be embedded with all functionality[links and dynamic toggle] while making sure that it is compatible with Doxygen output.
Draw.io is supporting embedding option only with Google Drive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing blocking us here right now. The problem is we do not have control over when draw.io goes down or things change there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you use an .svg file checked into Github as part of the page, instead of using draw.io? Does something go wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing blocking us here right now. The problem is we do not have control over when draw.io goes down or things change there.
I'm looking into this and I think it will be possible after exporting the diagram as HTML and then keeping it in repo.(Still trying to implement the easter egg rest of the part is working)
I'll convert this PR to draft for the time!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I didn't follow the design from the beginning so maybe this was already discussed. But I wonder whether https://github.com/mermaid-js/mermaid is an open-source alternative worth considering here?
Thanks for the suggestion, it seems like a good alternative. However, Draw.io was already finalized for diagrams.
- Mermaid also probably doesn't support animation.
This is the main concern here, as current GitHub Hosted SVG in this PR can be easily embedded. But they don't support animation toggle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you use an .svg file checked into Github as part of the page, instead of using draw.io? Does something go wrong?
The Easter egg toggle won't work!! Rest, there won't be any other change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I am fine giving up the Easter egg toggle if the docs page can rely only on files provided from one server, rather than requiring draw.io to be up and accessible as well.
docs/doxygen/Doxymain.md
Outdated
<div class="diagram-container"> | ||
<!-- draw.io diagram --> | ||
<div class="mxgraph" style="" data-mxgraph="{"highlight":"#0000ff","lightbox":false,"nav":true,"edit":"_blank","url":"https://drive.google.com/uc?id=16X8Z_4-J8mHQPxuxm9HjWppPMTTXZdZ6&export=download"}"></div> | ||
<script type="text/javascript" src="https://viewer.diagrams.net/embed2.js?&fetch=https%3A%2F%2Fdrive.google. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing blocking us here right now. The problem is we do not have control over when draw.io goes down or things change there.
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
- Moved diagram to Assets [Kept for reference only] Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com> Signed-off-by: Adarsh Rawat <adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com> Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com> Signed-off-by: Adarsh Rawat <adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Open links in new tab Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Fix : Switched to HTML file stored in this PR [GitHub repo] for embedding Diagram SVG. Now we are not relying on Draw.io or Google Drive. p.s. I have updated the Demo link also, do let me know if there is any modification you would like on the diagram. |
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
Signed-off-by: Adarsh <Adarshbunny293@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix : Switched to HTML file stored in this PR [GitHub repo] for embedding Diagram SVG. Now we are not relying on Draw.io or Google Drive.
p.s. I have updated the Demo link also, do let me know if there is any modification you would like on the diagram.
This is great, thanks! We can figure out the other issues in subsequent PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
View live demo
Home page
Demo of Easter egg and diagram -
Home.page.feat.mp4
New Sections included in documentation
Update in Website layout
Update in color scheme
Current Colors
#1779c4
#1982d2
#335c80
#5ca8e2
#70b1e9
#4779ac
Updated Colors
#8cc63f
#8cc63f
#4b6c21
#4b6c21
#c4f0a1
#c4f0a1