Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PINS programs. #4799

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Update the PINS programs. #4799

merged 3 commits into from
Jul 16, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jul 12, 2024

The PINS programs at https://github.com/sonic-net/sonic-pins/blob/main/sai_p4/instantiations/google have recently been updated. They are becoming more complex which can help in stress testing the compiler and associated tools.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Jul 12, 2024
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, but looks like some of the tests with these new files are failing for a reason not obvious to me from the logs.

@fruffy
Copy link
Collaborator Author

fruffy commented Jul 13, 2024

Seems like a good idea to me, but looks like some of the tests with these new files are failing for a reason not obvious to me from the logs.

I believe it's this problem: p4lang/PI#585
Need to check whether there is a workaround possible.

@fruffy
Copy link
Collaborator Author

fruffy commented Jul 15, 2024

The fix is to remove the p4runtime_translation annotation until it is supported: #3857. Or we could add the tests to Xfails.

Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit bc05831 Jul 16, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/pins branch July 16, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants