Require type decl in for..in loops #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-forinfix
branch
from
6c11830
to
35ab354
Compare
jafingerhut
approved these changes
Jul 16, 2024
ChrisDodd
force-pushed
the
cdodd-forinfix
branch
from
35ab354
to
37810ff
Compare
vlstill
reviewed
Jul 16, 2024
| builder.supressStatementSemi(); | ||
| visit(di, "decl"); | ||
| } else { | ||
| visit(s->ref, "ref"); |
There was a problem hiding this comment.
Can this branch be used for a code that is accepted by the parser?
There was a problem hiding this comment.
No -- any code that hits this branch will dump in a form that can't be parsed. Perhaps this should be a BUG instead, as this should not happen -- there should always be a declaration of the symbol in scope.
ChrisDodd
force-pushed
the
cdodd-forinfix
branch
from
37810ff
to
5f2a2a1
Compare
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
fruffy
added
the
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.