Make SymbolicVariable part of the core IR. #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
core
|
I guess the main question is: what is the expected usage of |
ChrisDodd
approved these changes
Jul 30, 2024
vlstill
approved these changes
Jul 31, 2024
Moving it to the |
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/symbolic_variable
branch
from
a620fff
to
37cc4da
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
…4768) * Make SymbolicVariable part of the core IR. (#4840) Signed-off-by: fruffy <fruffy@nyu.edu> * Replace boost::container::flat_map with absl::btree_map in P4Tools. Signed-off-by: fruffy <fruffy@nyu.edu> * Review comments. Signed-off-by: fruffy <fruffy@nyu.edu> * Rebase on solver move PR. Signed-off-by: fruffy <fruffy@nyu.edu> --------- Signed-off-by: fruffy <fruffy@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solver.h is part of the IR folder and uses
IR::SymbolicVariable. ButIR::SymbolicVariableis only usable when the p4tools back end is enabled. MoveIR::SymbolicVariableto the top-level IR.We can also move
solver.hinto the p4tools folder again. I do not think it is used by other back ends.