Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[p4fmt]: Add a pretty printer for p4fmt. #4862

Merged
merged 17 commits into from
Aug 22, 2024
+1,766 −2
Merged

[p4fmt]: Add a pretty printer for p4fmt. #4862

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2524925
[p4fmt]: pretty printer for p4fmt
snapdgn Aug 10, 2024
46e1275
remove nested namespace from 'p4fmt'
snapdgn Aug 13, 2024
55abd59
rename 'toP4' to 'P4Formatter'
snapdgn Aug 13, 2024
50f8683
update header guard
snapdgn Aug 13, 2024
d496c8e
add a catchall preoder method
snapdgn Aug 13, 2024
7e9280f
clean member variables & methods
snapdgn Aug 13, 2024
dded809
mark single args constructors as explicit
snapdgn Aug 13, 2024
7800b5e
rebase & update namespace
snapdgn Aug 16, 2024
ecbd6b7
restructure p4fmt dir
snapdgn Aug 16, 2024
c74bbdb
Address PR review suggestions [partial]
snapdgn Aug 16, 2024
e9c2c9e
Refactor repetitive collection iteration with a reusable `visitCollec…
snapdgn Aug 16, 2024
4b22b49
remove top level qualified P4 namespace
snapdgn Aug 16, 2024
197bdd8
[`visitCollection`]: deal with the enumerator type
snapdgn Aug 16, 2024
e4e1db8
use RAII objects for separator management
snapdgn Aug 19, 2024
76e121d
use `std::filesystem::path` for path manipulations
snapdgn Aug 19, 2024
cbfa732
nits
snapdgn Aug 20, 2024
cf63b9f
Merge branch 'main' into pp-p4fmt
fruffy Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backends/p4fmt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ set(FMT_SRCS
p4fmt.cpp
options.cpp
main.cpp
p4formatter.cpp
)

set(REFCHECK_SRCS
refcheck.cpp
options.cpp
p4fmt.cpp
p4formatter.cpp
)

# p4fmt
Expand Down
4 changes: 2 additions & 2 deletions backends/p4fmt/p4fmt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

#include "frontends/common/parseInput.h"
#include "frontends/common/parser_options.h"
#include "frontends/p4/toP4/toP4.h"
#include "ir/ir.h"
#include "lib/compile_context.h"
#include "lib/error.h"
#include "options.h"
#include "p4formatter.h"

namespace P4::P4Fmt {

Expand All @@ -24,7 +24,7 @@ std::stringstream getFormattedOutput(std::filesystem::path inputFile) {
return formattedOutput;
}

auto top4 = P4::ToP4(&formattedOutput, false);
auto top4 = P4Fmt::P4Formatter(&formattedOutput);
// Print the program before running front end passes.
program->apply(top4);

Expand Down
Loading
Loading