Fix linter complaints in the validateStringAnnotations pass and enable -werror for MacOS.

[fruffy]

No description provided.

[vlstill]

Thanks for this. I should not have copy-pasted another validator, sorry. How come the CI did not catch this? Or are you running a different linter somewhere?

[fruffy]

How come the CI did not catch this?

The sanitizer only runs nightly and uses -werror. https://github.com/p4lang/p4c/actions/runs/10499346080/job/29085947562. The other issues are just clang-tidy complaints, which are optional.

We can enable -werror on all other runs, I do not see any reason why not.

Edit: We are using -werror but the sanitizer is the only clang build.

[vlstill]

We can enable werror on all other runs, I do not see any reason why not.

Edit: We are using werror but the sanitizer is the only clang build.

I see, it makes sense that clang finds different bugs. It would be good to have clang build in the normal suite, but I'm not sure we have capacity for it. Do the macOS builds have Werror? I'm not sure if apple clang provides the same errors, but that might be worth the try if it is not already enabled there (and if it does not produce too many apple-specific warnings).