Add empty block for trailing case(s) with no code. #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
approved these changes
Aug 29, 2024
|
The updated expected output P4 programs look correct to me. As far as I can tell, the new expected output files are all functionally equivalent to the old ones. Is there a test program we can add that has different packet in/out behavior without vs. with this compiler fix? |
fruffy
added
core
ChrisDodd
force-pushed
the
cdodd-caseremoval
branch
from
335bee2
to
862251f
Compare
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 12.7.3 in the spec, a trailing case label in a switch with no code is treated as if it has a
{}after it; we were instead just removing it.The main effect here is properly generate an error (later) if that case label is a duplicate, rather than silently removing it.