Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 4 tests that are completely identical to other tests that remain #4890

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jafingerhut
Copy link
Contributor

Main motivation is simply to save a bit of time in testing, with no loss in test coverage.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Aug 29, 2024
@jafingerhut
Copy link
Contributor Author

Attaching a little bash script one can run to diff the removed files with other test files that are identical, to show minor differences in expected output files that depend only upon the file names, so functionally the same.
diff.sh.txt

Main motivation is simply to save a bit of time in testing, with
no loss in test coverage.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
@jafingerhut jafingerhut added this pull request to the merge queue Aug 29, 2024
Merged via the queue into p4lang:main with commit 0b90b08 Aug 29, 2024
18 checks passed
@jafingerhut jafingerhut deleted the remove-duplicate-tests1 branch August 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants