Support annotations for actions params and match keys. (#463) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
requested changes
Apr 17, 2017
| @@ -938,6 +940,7 @@ class P4RuntimeSerializer { | |||
| auto paramName = controlPlaneName(actionParam); | |||
| param->set_id(index++); | |||
| param->set_name(paramName); | |||
| addAnnotations(param, annotations); | |||
There was a problem hiding this comment.
this is incorrect, it picks up the action's annotations, not the parameter's annotations
There was a problem hiding this comment.
Ack, you're right. Fixing now.
sethfowler
force-pushed
the
seth/support-annotations-for-actions-params-and-match-keys
branch
from
8dea55a
to
ca9d25b
Compare
|
@antoninbas OK, it's fixed. |
antoninbas
approved these changes
Apr 17, 2017
sethfowler
deleted the
seth/support-annotations-for-actions-params-and-match-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements P4Runtime serializer support for annotations on action parameters and match keys.
I had to make KeyElement implement IAnnotated; this is just an oversight of the current code, since KeyElement already contains a list of annotations.