Make --top4 matching case-insensitive. #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
core
vlstill
reviewed
Sep 27, 2024
There was a problem hiding this comment.
I suggest to just use std::regex::icase (https://en.cppreference.com/w/cpp/regex/syntax_option_type). This would also work if the regex contained uppercase symbols, which would just fail to match with the current solution.
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/lower_case_top4
branch
from
de6ea58
to
b472176
Compare
What's an example of an uppercase symbol? |
I just meant letters :-). I.e. matching e.g. |
vlstill
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up in #4923. I do not see a reason why the pattern matching here needs to be case-sensitive. Case-insensitive matching can be more convenient.