Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Tools] Clean up use of ::P4 prefix for errors, warnings, and logs. #4930

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[P4Tools] Clean up use of ::P4 prefix for errors, warnings, and logs. #4930

merged 2 commits into from
Oct 1, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Sep 27, 2024

No description provided.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Sep 27, 2024
@fruffy fruffy requested a review from vlstill September 27, 2024 21:17
@fruffy
Copy link
Collaborator Author

fruffy commented Sep 27, 2024

Unclear why p4c-lint is failing. The formatter makes no changes locally...

@vlstill
Copy link
Contributor

vlstill commented Sep 30, 2024

Unclear why p4c-lint is failing. The formatter makes no changes locally...

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

vlstill
vlstill approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@qobilidop qobilidop mentioned this pull request Sep 30, 2024
Open
16 tasks
@fruffy
Copy link
Collaborator Author

fruffy commented Sep 30, 2024 •
edited
Loading

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

I made sure the clang-format versions are the same. Maybe it doesn't pick up the config correctly.

@fruffy
Copy link
Collaborator Author

fruffy commented Sep 30, 2024

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

I made sure the clang-format versions are the same. Maybe it doesn't pick up the config correctly.

The problem was that the branch was opened from a different repository... Should be fixed now.

@fruffy fruffy added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 30, 2024
@fruffy
Prefix cleanup for warning and error.
b63d7f7 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy
Cleanup others.
7cbfa49 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy added this pull request to the merge queue Oct 1, 2024
Merged via the queue into p4lang:main with commit a74f2d5 Oct 1, 2024
18 checks passed
@fruffy fruffy deleted the fruffy/p4_prefix_cleaning branch October 1, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlstill vlstill vlstill approved these changes

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @vlstill