Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fedora CI build. #4957

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix Fedora CI build. #4957

merged 1 commit into from
Oct 13, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Oct 10, 2024 •
edited
Loading

The Fedora installation is failing because execution of sudo is not viable any more in the installation script. Let's see whether this workaround can fix it.
This is the error that occurs within Docker:

 sudo: PAM account management error: Authentication service cannot retrieve authentication info
sudo: a password is required

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Oct 10, 2024
@fruffy fruffy force-pushed the fruffy/fedora branch 2 times, most recently from 970cf7c to 96020a7 Compare October 10, 2024 12:54
@fruffy fruffy added the run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. label Oct 10, 2024
@fruffy fruffy force-pushed the fruffy/fedora branch 4 times, most recently from 39e36fa to 0bd43c4 Compare October 10, 2024 21:38
@fruffy fruffy marked this pull request as ready for review October 10, 2024 21:40
@fruffy fruffy mentioned this pull request Oct 11, 2024
Merged
@fruffy fruffy force-pushed the fruffy/fedora branch 5 times, most recently from 045ae24 to 964c290 Compare October 11, 2024 18:54
@fruffy
Fix Fedora CI build.
e25bbfc 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy requested a review from rst0git October 11, 2024 19:53
@kfcripps kfcripps requested a review from asl October 11, 2024 21:21
jafingerhut
jafingerhut approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approving review is not based upon any detailed knowledge that the changes made are good from reading the code changes, but simply from the fact that the Fedora CI test is passing.

rst0git
rst0git approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fruffy Thank you for fixing this!

@rst0git rst0git added this pull request to the merge queue Oct 13, 2024
Merged via the queue into main with commit 80392f2 Oct 13, 2024
18 checks passed
@rst0git rst0git deleted the fruffy/fedora branch October 13, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rst0git rst0git rst0git approved these changes

@jafingerhut jafingerhut jafingerhut approved these changes

@asl asl Awaiting requested review from asl

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruffy @jafingerhut @rst0git