Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case of default CMake build mode. #4993

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix case of default CMake build mode. #4993

merged 1 commit into from
Nov 1, 2024
+1 −1

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Nov 1, 2024

Fixes #4991.

@fruffy
Fix case of default CMake build mode.
197bbe2 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Nov 1, 2024
@fruffy fruffy enabled auto-merge November 1, 2024 21:40
@fruffy fruffy added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit b35c89b Nov 1, 2024
20 checks passed
@fruffy fruffy deleted the fruffy/cmake_release branch November 1, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Currently cmake requires -DCMAKE_BUILD_TYPE=Release or similar option to build without error
2 participants
@fruffy @jafingerhut