Remove superfluous Tofino include. Make Tofino include paths fully qualified. #4998
+2,475
−2,476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
ChrisDodd
reviewed
Nov 4, 2024
| @@ -16,7 +16,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| #include "bf-p4c/arch/add_t2na_meta.h" | |||
| #include "backends/tofino/bf-p4c/arch/add_t2na_meta.h" | |||
There was a problem hiding this comment.
This should probably be just #include "add_t2na_meta.h" as it is in the same directory. No need for a full path.
Lots of other places this could be cleaned up too -- possibly a separate cleanup change?
There was a problem hiding this comment.
I guess this is a stylistic choice. Not many guides mention it but Google style guide recommends to qualify all paths: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
I guess to avoid accidental conflicts with includes?
I do not have a strong preference but the Tofino back end is not the only part which doesn't follow this style. So this likely should be a separate cleanup change.
hanw
approved these changes
Nov 4, 2024
|
Thanks for cleaning this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.