Fix many Tofino warnings. #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/tofino_warnings
branch
3 times, most recently
from
6083b32 to
53faadf
Compare
fruffy
force-pushed
the
fruffy/tofino_warnings
branch
from
53faadf to
0951347
Compare
fruffy
force-pushed
the
fruffy/tofino_warnings
branch
3 times, most recently
from
15dc354 to
7fe4eb5
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/tofino_warnings
branch
from
7fe4eb5 to
1a9e868
Compare
asl
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually makes it much easier to see what's going on and fixes a bunch of low-hanging fruits. These are warnings thrown by Clang.