Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to unbreak Tofino backend due to recent annotations changes #5015

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Try to unbreak Tofino backend due to recent annotations changes #5015

merged 4 commits into from
Nov 13, 2024

Conversation

asl
Copy link
Contributor

@asl asl commented Nov 12, 2024

No description provided.

asl added 2 commits November 12, 2024 16:34
@asl
Fix annotations usage in Tofino frontend bits
b1f2ceb 
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl
Try to unbreak Tofino backend due to recent annotations changes
39d1004 
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl asl requested review from hanw and fruffy November 12, 2024 21:57
@asl asl added the tofino Topics related to the Tofino switch and back end. label Nov 12, 2024
@fruffy fruffy linked an issue Nov 12, 2024 that may be closed by this pull request
The Tofino back end is currently broken #5008
Closed
@asl
Simplify
8e67518 
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl asl requested a review from fruffy November 12, 2024 22:41
fruffy
fruffy reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, much appreciated! I think we can simplify things even further but for the interest of keeping things moving this is good enough. Just one clarification.

backends/tofino/bf-p4c/common/extract_maupipe.cpp Show resolved Hide resolved
backends/tofino/bf-p4c/ir/mau.cpp Outdated Show resolved Hide resolved
backends/tofino/bf-p4c/mau/adjust_byte_count.cpp Show resolved Hide resolved
backends/tofino/bf-p4c/mau/instruction_selection.cpp Show resolved Hide resolved
backends/tofino/bf-p4c/midend/desugar_varbit_extract.h Outdated Show resolved Hide resolved
@asl @fruffy
Update error message
548650b 
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl asl enabled auto-merge November 12, 2024 23:03
@fruffy fruffy linked an issue Nov 12, 2024 that may be closed by this pull request
Potential infinite recursion in Tofino backend #5014
Closed
@asl asl added this pull request to the merge queue Nov 13, 2024
Merged via the queue into p4lang:main with commit ddd368c Nov 13, 2024
19 checks passed
@asl asl deleted the tofino-ann branch November 13, 2024 01:29
@psivanup psivanup mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

@hanw hanw Awaiting requested review from hanw

Assignees
No one assigned
Labels
tofino Topics related to the Tofino switch and back end.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential infinite recursion in Tofino backend The Tofino back end is currently broken
2 participants
@asl @fruffy