Generate JSON actions and keys fields array even when they are empty #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbnogueira
force-pushed
the
fix_empty_json_fields
branch
from
6d26180 to
8a3adba
Compare
Generate JSON actions, keys fields array even when they are empty Also generate keysize = 0 whenever the keysize is zero instead of omitting it from the JSON Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
vbnogueira
force-pushed
the
fix_empty_json_fields
branch
from
8a3adba to
ad7d0a4
Compare
|
@komaljai please take a look when you have some time |
komaljai
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate JSON actions, keys fields array even when they are empty
Also generate keysize = 0 whenever the keysize is zero instead of
omitting it from the JSON file