Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PI submodule ref pointer #506

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fix PI submodule ref pointer #506

merged 1 commit into from
Apr 20, 2017

Conversation

antoninbas
Copy link
Member

No description provided.

@antoninbas antoninbas requested a review from cc10512 April 20, 2017 20:57
sethfowler
sethfowler approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@sethfowler sethfowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's land this ASAP.

@antoninbas antoninbas merged commit 960f1e5 into master Apr 20, 2017
@sethfowler sethfowler deleted the PI-submodule-ref-ptr-fix branch April 20, 2017 20:59
@antoninbas
Copy link
Member Author

I exceptionally used admin privileges to merge this without waiting for the Travis job to complete since it would have blocked all builds.

@sethfowler
Copy link
Contributor

That was a good move. Thanks.

@fefer fefer mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cc10512 cc10512 cc10512 approved these changes

@sethfowler sethfowler sethfowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoninbas @sethfowler @cc10512