Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid dereferencing in bmv2/inlining.cpp #514

Closed
wants to merge 1 commit into from

Conversation

antoninbas
Copy link
Member

Thanks to @teverman for reporting this issue. Only some compilers actually complain about this, which is very confusing to me...

@antoninbas
Copy link
Member Author

@teverman I submitted your patch.

Copy link
Contributor

@ChrisDodd ChrisDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird one -- the code is clearly illegal so I can't see any compiler not giving an error, but for some reason it works on the versions we normally run with. Is this code dead-code eliminated before the compiler checks it?

@ChrisDodd
Copy link
Contributor

Ah -- I see the propblem now -- this code is not currently built at all; this source file does not appear in Makefile.am. If we need it, it should probably be added to the makefile.

@antoninbas
Copy link
Member Author

That's reassuring... @ChrisDodd and @mbudiu-vmw should we remove this code then if it is not used?

@mihaibudiu
Copy link
Contributor

The file is probably checked-in by mistake; let's delete it.

@teverman
Copy link
Contributor

So it's breaking in our environment because it just globs all the cpp files from the bmv2 directory.

@antoninbas
Copy link
Member Author

PR #515 removes these files, as @mbudiu-vmw suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants