Add support for new ActionRef message in p4runtime #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfowler
approved these changes
Apr 26, 2017
| action_ref->set_id(id); | ||
| addAnnotations(action_ref, action.annotations); | ||
| // XXX(antonin): This is temporary for backward-compatibility; can be removed when all | ||
| // consummers gave moved from action_ids to action_refs. |
There was a problem hiding this comment.
s/consummers gave/consumers get
antoninbas
force-pushed
the
p4Runtime-p4info-update-action-refs
branch
from
74417b9
to
7048188
Compare
|
annotations on actions show up in the |
|
Ah yes, that's a good point. We now have both sets of annotations exposed, which is a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reaction to the following PI update: p4lang/PI#135