Add Doxygen comments for the ResetHeaders pass. #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
May 2, 2017
frontends/p4/resetHeaders.cpp
Outdated
| const IR::Type* type, | ||
| const IR::Expression* expr, | ||
| IR::Vector<IR::StatOrDecl>* resets) | ||
| { |
There was a problem hiding this comment.
I think that cplint will want the brace on the previous line.
cole-barefoot
force-pushed
the
document_ResetHeaders
branch
from
306fd34 to
3cf0e55
Compare
cole-barefoot
force-pushed
the
document_ResetHeaders
branch
from
3cf0e55 to
3a006eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also format
DoResetHeaders::generateResetssignature to be less than 80 characters wide.