Support for 'bool' type in P4_14 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
May 3, 2017
|
The typechecker already has support for boolean types as all comparisons
are booleans. Legacy P4_14 programs tend to use bit<1> as an alias for
boolean, so the P4_14 typechecker allows implicit conversions both ways.
…On Wed, May 3, 2017 at 10:16 AM, Mihai Budiu ***@***.***> wrote:
***@***.**** approved this pull request.
I am surprised that this is all that is needed.
I would expect that the typechecker needs to be updated too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#558 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD4c8St4VFg29kyDMDK-MYZjIYDDU42rks5r2LZ-gaJpZM4NPo82>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial addition that was missing in the P4_14 frontend.