Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating action_ids for p4runtime tables #565

Merged
merged 4 commits into from
May 4, 2017
Merged

Stop generating action_ids for p4runtime tables #565

merged 4 commits into from
May 4, 2017

Conversation

antoninbas
Copy link
Member

We are now using action_refs, which include annotations in addition to
the id.

@antoninbas
Stop generation action_ids for p4runtime tables
69bda54 
We are now using action_refs, which include annotations in addition to
the id.
@antoninbas antoninbas requested a review from sethfowler May 4, 2017 17:46
sethfowler
sethfowler approved these changes May 4, 2017
View reviewed changes
Copy link
Contributor

@sethfowler sethfowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@antoninbas antoninbas changed the title Stop generation action_ids for p4runtime tables Stop generating action_ids for p4runtime tables May 4, 2017
@antoninbas antoninbas merged commit da61ba3 into master May 4, 2017
@antoninbas antoninbas deleted the p4runtime-tables-no-more-action-ids branch May 4, 2017 21:37
@fefer fefer mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethfowler sethfowler sethfowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoninbas @sethfowler