Fix bmv2 backend crash for unused action selectors #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
requested changes
May 6, 2017
|
|
||
| action drop() { smeta.drop = 1; } | ||
|
|
||
| action_selector (HashAlgorithm.identity, 32w1024, 32w10) as; |
There was a problem hiding this comment.
Where is the unused selector?
When an action selector is declared as a control local but never referenced by a table, the compiler cannot figure out the selector input, which means the action selector cannot be included in the bmv2 JSON.
antoninbas
force-pushed
the
bmv2-unused-selector-fix
branch
from
7c2f154
to
7e42b47
Compare
|
@mbudiu-vmw my bad I pushed the wrong test file. I fixed it. |
|
@mbudiu-vmw could you update your review for this? |
mihaibudiu
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an action selector is declared as a control local but never
referenced by a table, the compiler cannot figure out the selector
input, which means the action selector cannot be included in the bmv2
JSON.