Issue430 #626
Merged
Issue430 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2017 14:36
hanw
reviewed
May 13, 2017
| @@ -204,6 +204,8 @@ MidEnd::MidEnd(CompilerOptions& options) { | |||
| new P4::TableHit(&refMap, &typeMap), | |||
| new P4::SynthesizeActions(&refMap, &typeMap, new SkipControls(skipv1controls)), | |||
| new P4::MoveActionsToTables(&refMap, &typeMap), | |||
| new P4::MidEndLast(), | |||
| // Here is actually the start of the BMv2-specific back-end | |||
There was a problem hiding this comment.
Maybe we can consider moving them to backend.cpp?
There was a problem hiding this comment.
What is "them"?
After this point there are still a few mid-end passes run, but logically what follows is bmv2-specific.
There was a problem hiding this comment.
I don't have any problem moving the invocation of these passes to another file.
ChrisDodd
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes the semantics of digest to be eager: the digest is evaluated at the place of the call, and not at the end of the pipeline. This can break P4-14 programs which depended on the old behavior, but we hope that no one really did. P4-16 does not allow such semantics.
The new test does not really exhibit this case, since the conversion is in the back-end, and the generated reference file is in the mid-end, but the test file can be used to manually inspect that the transformation is correct.