Fix for issue #629 #636
Merged
Fix for issue #629 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
approved these changes
May 15, 2017
mihaibudiu
pushed a commit
that referenced
this pull request
May 30, 2017
* Fix for issue #638 * IRGen fixes - support for autogenerating methods in nested classes - support for friend functions - misc bug fixes * cpplint fixes * Update comment * Minor change in bmv2 backend: set action_const (#652) In the bmv2 JSON, a match-table can indicate that its default action is constant (using 'action_const') and that the default action entry (action + action parameter values) is constant (using 'action_entry_const'). `action_entry_const == true => action_const == true`. The bmv2 backend was setting 'action_entry_const' correctly, but 'action_const' was always set to false. Note that P4_16 does not make a difference between the 2, the presence of `const` in the P4_16 source implies that both attributes should be true. * Fix for issue #629 (#636) * Support emits of structs; test parsing of varbit fields (#634) * Support emits of structs; test parsing of varbit fields * Fixes issue #447 and #630 * Updated reference outputs * Additional tests and bug-fixes for varbits * Fix for issue #638 * Allow empty actions list in tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The P4-16 spec has removed the two-argument emit method of packet_out.