Don't include json_loader.h in ir.h #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR I've summoned from an old branch.
p4c takes a long time to compile, and one of the biggest factors is duplicate template instantiations in different translation units. We've worked around this to some degree with unified builds, but it'd be much better to resolve the underlying problem.
This patch takes one small step in that direction by eliminating the need to include
json_loader.h
inir.h
. This is accomplished by adding forward declarations forJSONLoader
where needed (including inir-generated.cpp
) and moving the code that referencesJSONLoader
fromir-inline.h
intojson_loader.h
itself.I had tried to do the same for
json_generator.h
, but while I have a patch that does it, it requires some icky explicit template instantiations. Getting rid of it cleanly would require a redesign that didn't implementtoJSON()
as a virtual method.