Fix for issue #619 #656
Fix for issue #619 #656
Conversation
Makefile.am
Outdated
| @@ -154,6 +154,8 @@ cpplint_FILES += $(noinst_HEADERS) | |||
| clean-local: | |||
| -rm -f $(BUILT_SOURCES) $(CLEANFILES) | |||
|
|
|||
| check: cpplint | |||
|
|
|||
There was a problem hiding this comment.
Is this correct, or should it be check-local: ? I'm never sure with automake. Possibly also redirect stdout of cpplint to avoid the spew of "processing x" messages that are mostly uninteresting?
There was a problem hiding this comment.
stupid cpplint writes the message on stderror.
Want me to change the python file?
There was a problem hiding this comment.
Re: check-local, I wondered that myself. It does seem more idiomatic, so perhaps that by itself is an argument in its favor.
There was a problem hiding this comment.
Added a --quiet option to cpplint
There was a problem hiding this comment.
The only difference I could find is that if you use check-local and -j it will run the cpplint check in parallel with other checks, while if you use check it will not (and will bail out if cpplint fails, before running any tests).
I am not sure this is the best way to do this, but it seems to work.